-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
countly-server runs as root #102
Comments
Agreed - there could be a need to check that for other services as well.. If you need, we can create two servers (RHEL/Ubuntu) for you so you can make your tests and send a PR. |
The next few weeks I'll be quite busy deploying our app and website, but afterwards I'll investigate setting up a few Vagrant-based scripts to run some automated tests in Ubuntu and RHEL. Since I'm on Debian right now, I went through the setup manually and didn't look at the automated install scripts yet. |
Many thanks for your interest 💯 |
There's a fix in my feature branch milgner/countly-server@db971f7. Should I wait for #103 to be closed or should I push my changes to the same branch? It's not much code after all but I usually prefer to keep pull requests topical. |
Based on provided example implemented installing countly as another user here: 89c950d So there are now two scripts countly.install.sh which installs as root You still need to run install script as root though |
The supervisord configuration specifies
user=root
which in itself is doubtful whether it's a good idea but could be tolerated.But then, the application user isn't overriden in neither
program:countly-dashboard
orprogram:countly-api
sections.Right now I don't have access to Ubuntu or RHEL systems to update the installer scripts but as I'm currently modifying the configuration files in this regard, I'd be willing to contribute a PR if you like.
Do you have a CI system to test these changes on your target platforms?
The text was updated successfully, but these errors were encountered: