Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuance special null description #1262

Conversation

pataegrillo
Copy link
Contributor

This allows null to be passed as a description when creating an issuance. This will make counterparty to use the last issuance description for the asset

@jdogresorg
Copy link
Contributor

jdogresorg commented Oct 11, 2023

description testing

  • Set asset description to some text - 1156c7e2f2bafe80072aa9dc4b396dba5bb8d3d3eb2687ff0a78d2c526c1335a
    • Verify description is set - OK
  • Do issuance with description: null - 3d3bb866a4d9777507c90148df37241b0296148617a77d4ba850f49a4401c499
    • Verify description did not change - OK
  • Do issuance with description omitted - 745d3cb49d141e06fcec2547dee2de98ce1a75d9521010493b5b97fa8339f268
    • Verify description did not change - OK
  • Transfer asset ownership of BDUSSY with description: null - 0324a71067fa62f328e0302064202122c59cbdd5cd291fb528bf0a410d9dd85a
    • Verify description did not change - OK
  • Transfer asset ownership of BDUSSY with description omitted from API request - ef37785debeff00afa4846f2ab29c195b875ad7da483fd598807fd8097ef92c2
  • Verify description did not change - OK
  • Do issuance on numeric asset with description: null - 7db3f442f29ca534ea2e32bef41de2bb9966b6a5eb20f55404f1bc3098cccf0b
    • Verify description did not change - OK
  • Do issuance on subasset with description: null - a223a6c31993598a960bfcede618f3b18068a7b513786d6bc28697476b5ea38d
    • Verify description did not change - OK
sqlite> select * from issuances order by block_index desc limit 7;
34812|a223a6c31993598a960bfcede618f3b18068a7b513786d6bc28697476b5ea38d|0|2532220|A17238770146495238319|1|0|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|0|0|0|0.0|Damn dat bdussy be stank|0|0|valid|BDUSSY.stank|0
34813|7db3f442f29ca534ea2e32bef41de2bb9966b6a5eb20f55404f1bc3098cccf0b|0|2532220|A7767564156567597000|100000000|1|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|0|0|0|0.0|*xcp.coindaddy.io/A7767564156567597000.json|0|0|valid||0
34811|ef37785debeff00afa4846f2ab29c195b875ad7da483fd598807fd8097ef92c2|0|2532219|BDUSSY|0|1|mvThcDEbeqog2aJ7JNj1FefUPaNdYYGqHt|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|1|0|0|0.0|Testing description null updates|0|0|valid||0
34810|0324a71067fa62f328e0302064202122c59cbdd5cd291fb528bf0a410d9dd85a|0|2532213|BDUSSY|0|1|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|mvThcDEbeqog2aJ7JNj1FefUPaNdYYGqHt|1|0|0|0.0|Testing description null updates|0|0|valid||0
34809|745d3cb49d141e06fcec2547dee2de98ce1a75d9521010493b5b97fa8339f268|0|2532211|BDUSSY|0|1|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|0|0|0|0.0|Testing description null updates|0|0|valid||0
34808|3d3bb866a4d9777507c90148df37241b0296148617a77d4ba850f49a4401c499|0|2532210|BDUSSY|0|1|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|0|0|0|0.0|Testing description null updates|0|0|valid||0
34807|1156c7e2f2bafe80072aa9dc4b396dba5bb8d3d3eb2687ff0a78d2c526c1335a|0|2532209|BDUSSY|0|1|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|n1BiPncf1S9P83DSPpFwrAH2VqccD8KPeJ|0|0|0|0.0|Testing description null updates|0|0|valid||0

Looks good in testing

@jdogresorg jdogresorg merged commit f57810e into CounterpartyXCP:master Oct 11, 2023
@jdogresorg jdogresorg mentioned this pull request Nov 17, 2023
@jotapea
Copy link
Contributor

jotapea commented Nov 22, 2023

This will make counterparty to use the last issuance description for the asset

See CounterpartyXCP/Forum#109 (reply in thread). The copying of the last description is problematic by itself, so I'm not sure we should continue working on the current approach when we are already discussing a deeper solution. Why not wait for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants