-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issuance special null description #1262
Merged
jdogresorg
merged 4 commits into
CounterpartyXCP:master
from
pataegrillo:issuance_special_null_description
Oct 11, 2023
Merged
Issuance special null description #1262
jdogresorg
merged 4 commits into
CounterpartyXCP:master
from
pataegrillo:issuance_special_null_description
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…description of the last issuance for that asset
# Conflicts: # counterpartylib/protocol_changes.json
jdogresorg
approved these changes
Oct 11, 2023
|
Merged
See CounterpartyXCP/Forum#109 (reply in thread). The copying of the last description is problematic by itself, so I'm not sure we should continue working on the current approach when we are already discussing a deeper solution. Why not wait for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows null to be passed as a description when creating an issuance. This will make counterparty to use the last issuance description for the asset