Repository navigation
fix(lang): forward observe through the worker bridge - #2252
Merged
Merged
Conversation
The bridge forwards only the handler methods listed in METHODS, and observe was missing. A run hosted by a manager goes through the bridge, so a waitUntil failed on its first observation with L4000 "host.options.handler.observe is not a function". The walker cells and the in-process differential suite never cross the bridge, so nothing caught it. Adds observe to METHODS; the worker-side proxy and the host-side dispatch guard both derive from it. Adds a smoke cell that runs a waitUntil program through runInWorker with a bridged handler, and a patch changeset for @cotal-ai/lang. Fixes Cotal-AI#2239.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2239.
The worker bridge only forwarded a fixed list of effect handler methods, and
observewas not on it. AwaitUntilrun hosted by a manager therefore failed with "host.options.handler.observe is not a function". This addsobserveto the forwarded list, with a smoke check that fails without the fix, and a patch changeset for@cotal-ai/lang.Checked on the committed HEAD:
pnpm build:emitpasses and the lang smoke run passes (42 of 42; the two new checks fail against the previous bridge.ts).