Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab bar controller dynamically adds & removes child view controllers #923

Merged
merged 3 commits into from
Oct 22, 2017
Merged

Tab bar controller dynamically adds & removes child view controllers #923

merged 3 commits into from
Oct 22, 2017

Conversation

markst
Copy link
Contributor

@markst markst commented Oct 20, 2017 •
edited
Loading

This is one solution for #919 where by the tabs controllers are only added to the child view controller stack upon requested transitioning.
#920

@daniel-jonathan daniel-jonathan self-assigned this Oct 21, 2017
@daniel-jonathan daniel-jonathan changed the base branch from master to development October 21, 2017 18:36
daniel-jonathan
daniel-jonathan approved these changes Oct 22, 2017
View reviewed changes
Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@daniel-jonathan daniel-jonathan merged commit 36c2c4d into CosmicMind:development Oct 22, 2017
@markst markst mentioned this pull request Oct 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-jonathan daniel-jonathan daniel-jonathan approved these changes

Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markst @daniel-jonathan @DanielDahan