Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tab bar centering #1112

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Added tab bar centering #1112

merged 1 commit into from
Jul 6, 2018

Conversation

OrkhanAlikhanov
Copy link
Contributor

Implemented tab bar centering requested in #926

public enum TabBarCenteringStyle {
  case never
  case whenNeeded
  case always
}

Demo (9 mb gif)

daniel-jonathan
daniel-jonathan approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@daniel-jonathan daniel-jonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work :) Thank you!

Sources/iOS/TabBar.swift
return nil
}
fallthrough
case .always:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have case ..., we should always leave a space before the next case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just let XCode format those lines. Not sure if I understood but will keep track of your changes :)

@daniel-jonathan daniel-jonathan self-assigned this Jul 6, 2018
@daniel-jonathan daniel-jonathan merged commit cc90fb3 into CosmicMind:development Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-jonathan daniel-jonathan daniel-jonathan approved these changes

Assignees

@daniel-jonathan daniel-jonathan

Labels
enhancement material
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrkhanAlikhanov @daniel-jonathan