Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Label from contract's instantiate message #430

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 3, 2021

Resolves #376

This also removes the default label. As labels are required the contracts need to set them proper

@alpe alpe marked this pull request as ready for review March 4, 2021 08:00
@alpe alpe requested a review from ethanfrey March 4, 2021 08:00
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #430 (279efa9) into master (6bdac24) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   55.39%   55.34%   -0.05%     
==========================================
  Files          39       39              
  Lines        4022     4022              
==========================================
- Hits         2228     2226       -2     
- Misses       1615     1616       +1     
- Partials      179      180       +1     
Impacted Files Coverage Δ
x/wasm/internal/keeper/handler_plugin.go 78.26% <100.00%> (ø)
x/wasm/internal/keeper/keeper.go 88.36% <0.00%> (-0.56%) ⬇️

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all that discussion, such a simple fix.

Looks good

@ethanfrey ethanfrey merged commit 4307e9b into master Mar 4, 2021
@ethanfrey ethanfrey deleted the instantiate_encoder_376 branch March 4, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use label from WasmMsg:::Init if present
2 participants