Skip to content

run checks #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions x/wasm/types/tx_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package types

import (
"bytes"
"fmt"
"strings"
"testing"

Expand Down Expand Up @@ -79,6 +80,36 @@ func TestStoreCodeValidation(t *testing.T) {
}
}

// TestRawContractMessageVulnerabilities demonstrates known JSON handling vulnerabilities
func TestRawContractMessageVulnerabilities(t *testing.T) {
// Field length vulnerability: large string values are accepted without limit
var sb strings.Builder
const largeSize = 1 << 20
sb.Grow(largeSize + 16)
sb.WriteString(`{"foo":"`)
sb.WriteString(strings.Repeat("a", largeSize))
sb.WriteString(`"}`)
msgLarge := RawContractMessage([]byte(sb.String()))
require.NoError(t, msgLarge.ValidateBasic(), "large JSON field should be accepted")

// Depth vulnerability: deeply nested JSON is accepted without depth checks
nested := "{}"
const depth = 10000
for i := 0; i < depth; i++ {
nested = fmt.Sprintf("{\"a\":%s}", nested)
}
msgDeep := RawContractMessage([]byte(nested))
require.NoError(t, msgDeep.ValidateBasic(), "deeply nested JSON should be accepted")

// Numeric boundary vulnerability: extremely large numbers are accepted syntactically
msgNum := RawContractMessage([]byte(`{"num":123456789012345678901234567890}`))
require.NoError(t, msgNum.ValidateBasic(), "JSON with large numeric values should be accepted")

// Special character injection: control characters in strings are accepted if valid escape
msgSpecial := RawContractMessage([]byte(`{"ctrl":"\u0000"}`))
require.NoError(t, msgSpecial.ValidateBasic(), "JSON with special Unicode escapes should be accepted")
}

func TestInstantiateContractValidation(t *testing.T) {
// proper address size
goodAddress := sdk.AccAddress(make([]byte, 20)).String()
Expand Down