feat: Add a transaction hash to TransactionInfo #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
force-pushed
the
tkulik/feat/transaction_hash
branch
2 times, most recently
from
00bd0e5 to
1163f33
Compare
kulikthebird
force-pushed
the
tkulik/feat/transaction_hash
branch
from
1163f33 to
70e69c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=======================================
Coverage 45.18% 45.18%
=======================================
Files 79 79
Lines 10934 10935 +1
=======================================
+ Hits 4940 4941 +1
Misses 5556 5556
Partials 438 438
🚀 New features to boost your workflow:
|
chipshort
reviewed
May 20, 2025
| @@ -291,7 +292,8 @@ func NewEnv(ctx sdk.Context, contractAddr sdk.AccAddress) wasmvmtypes.Env { | |||
| }, | |||
| } | |||
| if txCounter, ok := TXCounter(ctx); ok { | |||
| env.Transaction = &wasmvmtypes.TransactionInfo{Index: txCounter} | |||
| hash := sha256.Sum256(ctx.TxBytes()) | |||
There was a problem hiding this comment.
Is this the same hash that is used in Cosmos SDK / CometBFT? A quick scan through the CometBFT code looks to me like they use something called tmhash. Not sure if that's the correct one though. We should test that.
We want to have the same hash here that is also shown on the cli when you submit the transaction (e.g. when you run wasmd tx wasm instantiate) and that is used to query information about the transaction (e.g. using wasmd q tx ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.