Skip to content

feat: IBCv2 WriteAcknowledgement handler #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

kulikthebird
Copy link
Member

No description provided.

@kulikthebird kulikthebird changed the base branch from main to feat/ibc_v2 March 18, 2025 14:39
@kulikthebird kulikthebird self-assigned this Mar 18, 2025
@kulikthebird kulikthebird linked an issue Mar 18, 2025 that may be closed by this pull request
@kulikthebird kulikthebird linked an issue Mar 18, 2025 that may be closed by this pull request
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 3 times, most recently from 5bf439e to 52465a2 Compare March 27, 2025 12:03
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 11.25000% with 71 lines in your changes missing coverage. Please review.

Project coverage is 44.84%. Comparing base (b88345d) to head (3c76cc6).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
tests/wasmibctesting/utils.go 0.00% 43 Missing ⚠️
x/wasm/keeper/handler_plugin.go 20.58% 27 Missing ⚠️
x/wasm/keeper/ibc2.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   44.72%   44.84%   +0.12%     
==========================================
  Files          79       79              
  Lines       11046    11034      -12     
==========================================
+ Hits         4940     4948       +8     
+ Misses       5668     5648      -20     
  Partials      438      438              
Files with missing lines Coverage Δ
app/app.go 85.23% <100.00%> (+0.02%) ⬆️
x/wasm/keeper/keeper_cgo.go 95.45% <100.00%> (ø)
x/wasm/keeper/ibc2.go 2.04% <0.00%> (ø)
x/wasm/keeper/handler_plugin.go 61.67% <20.58%> (-10.51%) ⬇️
tests/wasmibctesting/utils.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 2 times, most recently from db2beb6 to e6a9b88 Compare March 28, 2025 11:26
@kulikthebird kulikthebird changed the title feat: New IBCv2 msg handler feat: IBCv2 WriteAcknowledgement handler Mar 28, 2025
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 2 times, most recently from 6e22706 to fae9313 Compare March 28, 2025 11:47
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 5 times, most recently from 6d793f8 to 6fb67cc Compare April 11, 2025 14:04
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 2 times, most recently from 25e02c8 to 54f80f1 Compare April 15, 2025 07:44
Base automatically changed from feat/ibc_v2 to main April 30, 2025 12:45
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 2 times, most recently from 5547453 to 30480d5 Compare May 20, 2025 15:53
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch 2 times, most recently from e8afeba to 414f7b8 Compare May 20, 2025 17:15
@kulikthebird kulikthebird marked this pull request as ready for review May 20, 2025 17:15
@kulikthebird kulikthebird requested a review from aumetra May 20, 2025 17:15
@kulikthebird kulikthebird requested a review from chipshort May 20, 2025 17:15
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch from 414f7b8 to 1cbaaf2 Compare May 20, 2025 17:16
@kulikthebird kulikthebird force-pushed the tkulik/feat/write_ack branch from 1cbaaf2 to 3c76cc6 Compare May 21, 2025 06:55
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and nice refactor of the test functions

@kulikthebird kulikthebird merged commit 276870d into main May 22, 2025
18 of 19 checks passed
@kulikthebird kulikthebird deleted the tkulik/feat/write_ack branch May 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Handle async ack with IBCv2
2 participants