Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test integration update #1975

Merged
merged 7 commits into from
Aug 30, 2024
Merged

Test integration update #1975

merged 7 commits into from
Aug 30, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Aug 29, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (1d0c66c) to head (33aee72).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1975      +/-   ##
==========================================
- Coverage   54.33%   48.61%   -5.72%     
==========================================
  Files          65       65              
  Lines       10019    10019              
==========================================
- Hits         5444     4871     -573     
- Misses       4018     4717     +699     
+ Partials      557      431     -126
Files with missing lines Coverage Δ
tests/e2e/reflect_helper.go 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

@pinosu pinosu marked this pull request as ready for review August 29, 2024 13:12
@pinosu pinosu requested a review from chipshort August 29, 2024 13:12
tac0turtle
tac0turtle reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you. ill close my pr

chipshort
chipshort reviewed Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

tests/integration/migrations_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/recurse_test.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
chipshort
chipshort approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinosu pinosu merged commit 5519016 into main Aug 30, 2024
16 of 17 checks passed
@pinosu pinosu deleted the test_integration_update branch August 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle left review comments

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinosu @chipshort @tac0turtle