Add AllDenomMetadata BankQuery (backport #1426) #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* x/wasm: add AllDenomMetadata BankQuery * x/wasm: fix AllDenomMetadata BankQuery to have pagination and add DenomMetadata BankQuery * Use simplified pagination * Fix request conversion * Add unknown denom test cases * Add test for pagination conversion * Fix nits * Use wasmvm 1.3.0-rc.0 * Fix test --------- Co-authored-by: Nikhil Suri <nikhilsuri@comcast.net> (cherry picked from commit d2e9ace) # Conflicts: # x/wasm/keeper/query_plugins.go
|
I have resolved the conflicts. The DenomMetadata for sdk 45 and 47+ are differnet:
|
Codecov Report
@@ Coverage Diff @@
## releases/v0.3x #1518 +/- ##
==================================================
+ Coverage 57.68% 57.88% +0.19%
==================================================
Files 57 57
Lines 7534 7579 +45
==================================================
+ Hits 4346 4387 +41
- Misses 2879 2881 +2
- Partials 309 311 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1426 done by Mergify.
Cherry-pick of d2e9ace has failed:
Resolved the merge conflict manually