Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amino JSON representation changed between wasmd 0.45 and 0.50 (Cosmos SDK 0.50 upgrade) #1829

Closed
chipshort opened this issue Mar 12, 2024 · 0 comments · Fixed by #1844
Closed
Milestone

Comments

@chipshort
Copy link
Collaborator

This is a regression in wasmd 0.50. The json representation changed from:

{
  "account_number": "0",
  "chain_id": "testing",
  "fee": {
    "amount": [],
    "gas": "1000000"
  },
  "memo": "",
  "msgs": [
    {
      "type": "wasm/MsgInstantiateContract",
      "value": {
        "admin": "wasm1j8gw0uewunngtga7k7uwjkqa0tt0e4w5cz7tmx",
        "code_id": "4",
        "funds": [
          {
            "amount": "100",
            "denom": "ustake"
          }
        ],
        "label": "local0.1.0",
        "msg": {
          "beneficiary": "wasm1xumh4m362u2tqm26suk48t8yhlgmlulp0602k5",
          "verifier": "wasm1j8gw0uewunngtga7k7uwjkqa0tt0e4w5cz7tmx"
        },
        "sender": "wasm1j8gw0uewunngtga7k7uwjkqa0tt0e4w5cz7tmx"
      }
    }
  ],
  "sequence": "6"
}

to

{
  "account_number": "0",
  "chain_id": "testing",
  "fee": {
    "amount": [],
    "gas": "1000000"
  },
  "memo": "",
  "msgs": [
    {
      "type": "wasm/MsgInstantiateContract",
      "value": {
        "admin": "wasm17k7v9wmmus09pe6l5kumkpacly44ca3kg4qfrz",
        "code_id": "1",
        "funds": [
          {
            "amount": "100",
            "denom": "ustake"
          }
        ],
        "label": "local0.1.0",
        "msg": "eyJ2ZXJpZmllciI6Indhc20xN2s3djl3bW11czA5cGU2bDVrdW1rcGFjbHk0NGNhM2tnNHFmcnoiLCAiYmVuZWZpY2lhcnkiOiJ3YXNtMXgzcnpycWdwM3R5cGY4eWM3YTR3aGg1dDhmMHN2NHZmY2Zhenh0In0=",
        "sender": "wasm17k7v9wmmus09pe6l5kumkpacly44ca3kg4qfrz"
      }
    }
  ],
  "sequence": "3"
}

So the msg is now base64 encoded binary.

This is a regression and should be reverted

@chipshort chipshort added this to the v0.51 milestone Mar 12, 2024
@webmaster128 webmaster128 changed the title Amino JSON representation changed Amino JSON representation changed between wasmd 0.45 and 0.50 (Cosmos SDK 0.50 upgrade) Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant