Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Amino JSON representation #1844

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix Amino JSON representation #1844

merged 2 commits into from
Apr 11, 2024

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Mar 27, 2024 •
edited
Loading

Resolves #1829

@pinosu pinosu mentioned this pull request Mar 27, 2024
Closed
webmaster128
webmaster128 reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bangtabil
Copy link

Very nice!

webmaster128
webmaster128 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Let's make a 0.51 pre-release with that and test CosmJS against it

@pinosu pinosu merged commit 60375ab into main Apr 11, 2024
16 checks passed
@pinosu pinosu deleted the 1829-aminojson_fix branch April 11, 2024 12:57
@MSalopek MSalopek mentioned this pull request Jul 26, 2024
Merged
@mergify mergify bot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amino JSON representation changed between wasmd 0.45 and 0.50 (Cosmos SDK 0.50 upgrade)
3 participants
@pinosu @bangtabil @webmaster128