Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional proposal deposit to cw3-flex-multisig #751

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

0xekez
Copy link
Contributor

@0xekez 0xekez commented Jul 7, 2022

Resolves #742

This adds an optional proposal deposit to cw3-flex-multisig. In the process it refactors shared proposal code from the fixed and flex multisig into the cw3 package.

Both native and cw20 deposits are accepted.

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed everything yet, but those are comments so far.
Really nice work. 👍

contracts/cw3-flex-multisig/src/contract.rs Show resolved Hide resolved
contracts/cw3-flex-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-flex-multisig/src/msg.rs Outdated Show resolved Hide resolved
packages/cw20/Cargo.toml Outdated Show resolved Hide resolved
packages/cw3/src/deposit.rs Outdated Show resolved Hide resolved
packages/cw3/src/deposit.rs Show resolved Hide resolved
@0xekez
Copy link
Contributor Author

0xekez commented Jul 7, 2022

@ueco-jb thanks for the feedback! Addressed the first round.

@maurolacy maurolacy changed the title Add an optional proposal deposit to cw3-flex-multisig. Add an optional proposal deposit to cw3-flex-multisig Aug 23, 2022
@maurolacy
Copy link
Contributor

Can you rebase from main? And we release this in 0.16.

@maurolacy maurolacy added this to the 0.16.0 milestone Sep 14, 2022
@uint uint modified the milestones: 0.16.0, 0.17.0 Oct 17, 2022
@uint
Copy link
Contributor

uint commented Oct 25, 2022

@0xekez Could you update this to main? Or shall I pick this up? I promise this time we won't let this PR sit and get stale ;)

@uint uint self-requested a review November 1, 2022 14:51
@uint uint merged commit 1bf0b3c into CosmWasm:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport from DAO DAO: optionally charge to make proposal
4 participants