add execute msg to update minter #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
orkunkl
reviewed
Jun 8, 2022
orkunkl
reviewed
Jun 8, 2022
orkunkl
reviewed
Jun 8, 2022
orkunkl
reviewed
Jun 8, 2022
blue-note
force-pushed
the
jchalam/updateMinter
branch
from
fcb843c
to
0a6546b
Compare
|
Any updates on this? We would really like to have it for DAO migrations. |
maurolacy
reviewed
Jun 24, 2022
| return Err(ContractError::Unauthorized {}); | ||
| } | ||
|
|
||
| let minter = deps.api.addr_validate(&new_minter)?; |
There was a problem hiding this comment.
Nit: You can move this validation before loading the config, to save some cycles in case of error.
ethanfrey
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows current minter to update minter. Cap cannot be updated.