Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cw20-base: upgrade helper.ts to cosmjs 0.26.0 #406

Merged
merged 1 commit into from
Sep 11, 2021
Merged

cw20-base: upgrade helper.ts to cosmjs 0.26.0 #406

merged 1 commit into from
Sep 11, 2021

Conversation

spacepotahto
Copy link
Contributor

@spacepotahto spacepotahto commented Sep 9, 2021 •
edited
Loading

A few changes need to be made to helper.ts to be compatible with cosmjs 0.26.0:

  • Due to Remove default fees cosmos/cosmjs#833, CosmWasmFeeTable and default fees/gas are removed, so fees need to be calculated and and passed to SigningCosmWasmClient methods that submit transactions.
  • Due to Upgrade CosmWasm to wasmd 0.18 cosmos/cosmjs#863, only wasmd 0.18 backends are supported by cosmjs, and so pebblenet needs to be used in lieu of oysternet. Also there are some changes to the SigningCosmWasmClient.upload method signature.
  • The instantiate contract transaction keeps failing with amino signing (via Secp256k1HdWallet), so I changed to protobuf direct signing (via DirectSecp256k1HdWallet).
  • Miscellaneous: fixed the balance query msg, updated wasm sourceurl to point to v0.8.1, enhanced the doc block.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@orkunkl orkunkl self-requested a review September 9, 2021 17:38
@orkunkl
Copy link
Contributor

orkunkl commented Sep 9, 2021

I will test and merge this tomorrow

@JakeHartnell JakeHartnell mentioned this pull request Sep 9, 2021
Closed
@orkunkl orkunkl merged commit 847f9f8 into CosmWasm:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orkunkl orkunkl Awaiting requested review from orkunkl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacepotahto @CLAassistant @orkunkl