Add has to Path and Map #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Jul 12, 2021
| let key = TOKENS.key(&token_id); | ||
| if deps.storage.get(&key).is_none() { | ||
| key.save(deps.storage, &"".to_owned())?; | ||
| if !TOKENS.has(deps.storage, &token_id) { |
There was a problem hiding this comment.
When writing tests I found out the (untested) case would actually panic.
If you attempt to write b"" to the db.
(Which we added to avoid getting confusing results from the cosmos sdk storage layer). So I fixed that with real data as well.
There was a problem hiding this comment.
So, the original code had that flaw too?
There was a problem hiding this comment.
Oh, I guess you mean, as a key, not as a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261