Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to v0.11 2 #107

Merged
merged 14 commits into from
Oct 7, 2020
Merged

Migrate to v0.11 2 #107

merged 14 commits into from
Oct 7, 2020

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Oct 6, 2020

Migration of remaining contracts (cw3-fixed-multisig and cw721-base) to cosmwasm 0.11.0-alpha3.

Also, a couple of fixes and improvements that were left out in the previous iteration.

@maurolacy maurolacy self-assigned this Oct 6, 2020
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Thank you for finishing this.

use thiserror::Error;

#[derive(Error, Debug)]
pub enum ContractError {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice set of error messages

// we delete the escrow (TODO: expose this in Bucket for simpler API)
prefixed(&mut deps.storage, PREFIX_ESCROW).remove(id.as_bytes());
// we delete the escrow
escrows(&mut deps.storage).remove(id.as_bytes());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanfrey ethanfrey merged commit b575937 into master Oct 7, 2020
@ethanfrey ethanfrey deleted the migrate-to-v0.11-2 branch October 7, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants