Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom checksum generator #87

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Custom checksum generator #87

merged 2 commits into from
Oct 18, 2023

Conversation

DariuszDepta
Copy link
Member

Added a trait being an interface to provide custom checksum evaluator for contract's code.
Provided default implementation that is just SHA2 from text containing contract's code identifier.

@DariuszDepta DariuszDepta self-assigned this Oct 17, 2023
@DariuszDepta DariuszDepta added this to the 0.18.0 milestone Oct 17, 2023
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few minor things and one point of discussion

src/wasm.rs Outdated Show resolved Hide resolved
src/checksums.rs Outdated Show resolved Hide resolved
src/wasm.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DariuszDepta DariuszDepta merged commit 751761c into main Oct 18, 2023
7 checks passed
@DariuszDepta DariuszDepta deleted the checksum-generator branch October 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants