Move backtraces from OverflowError/DivideByZeroError into StdError #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
move-backtrace-in-stderror
branch
from
bb0224e
to
febb157
Compare
webmaster128
force-pushed
the
move-backtrace-in-stderror
branch
from
febb157
to
d5e5007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's keep
OverflowError/DivideByZeroErrorsimple and only create the backtrace when the conversion toStdErrorhappens.This fixes the
PartialEqimplementation ofOverflowErrorandDivideByZeroErrorwhich otherwise returns false when the backtrace is different.