Rename Extern to Deps
#589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ethanfrey
approved these changes
Oct 19, 2020
| /// Designed to allow easy dependency injection at runtime. | ||
| /// This cannot be copied or cloned since it would behave differently | ||
| /// for mock storages and a bridge storage in the VM. | ||
| pub struct Deps<S: Storage, A: Api, Q: Querier> { |
There was a problem hiding this comment.
Nice to pull this out. I was surprised to find it in traits when investigating
There was a problem hiding this comment.
Yeah this was probably the simplest way when the type was introduced to bundle the three traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 for #588. The VM part work cause big merge conflicts with the Wasmer Reborn work, so I'd do that later.