feat: Add Tx hash to TransactionInfo and make it non exhaustive #2480

kulikthebird · 2025-05-13T08:00:16Z

No description provided.

packages/std/src/types.rs

webmaster128 · 2025-05-13T08:25:19Z

I's also add the new transaction hash field here, a feature that was requested multiple times

kulikthebird · 2025-05-13T10:50:23Z

I've added the transaction checksum to the struct. Unless we make it optional, CosmWasm v3.0 won't be compatible with pre v3.0 blockchains.

chipshort · 2025-05-13T11:16:47Z

I've added the transaction checksum to the struct. Unless we make it optional, CosmWasm v3.0 won't be compatible with pre v3.0 blockchains.

What if we only add it if cosmwasm_3_0 is enabled? That will cause a problem with the constructor, but I think we can work around that somehow.

packages/std/src/types.rs

packages/std/src/query/mod.rs

packages/vm/src/instance.rs

packages/std/src/lib.rs

CHANGELOG.md

packages/std/src/testing/mock.rs

packages/std/src/types.rs

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

packages/std/src/binary.rs

packages/std/src/testing/mock.rs

packages/std/src/types.rs

webmaster128 · 2025-05-14T13:26:06Z

packages/std/src/utils.rs

+/// to be built in libraries like cw-multi-test.
+macro_rules! impl_hidden_constructor {
+    ( $response:ty, $( $field: ident : $t: ty),* ) => {
+        impl $response {


Maybe we can generalize this variable name. $my_struct?

packages/vm/src/testing/mock.rs

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

webmaster128

🐎🐎🐎

kulikthebird marked this pull request as ready for review May 13, 2025 08:00

kulikthebird commented May 13, 2025

View reviewed changes

packages/std/src/types.rs Outdated Show resolved Hide resolved

kulikthebird linked an issue May 13, 2025 that may be closed by this pull request

Make TransactionInfo non_exhaustive #2290

Closed

1 task

kulikthebird requested review from webmaster128 and chipshort May 13, 2025 08:03

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch 3 times, most recently from 7903df5 to 46187ac Compare May 13, 2025 10:22

kulikthebird changed the title ~~chore: Make the TransactionInfo struct non exhaustive~~ feat: Add Tx checksum to TransactionInfo and make it non exhaustive May 13, 2025

feat: Add Tx checksum to TransactionInfo and make it non exhaustive

da35964

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch from 7008f89 to da35964 Compare May 13, 2025 10:48

webmaster128 reviewed May 13, 2025

View reviewed changes

packages/std/src/types.rs Outdated Show resolved Hide resolved

chipshort reviewed May 13, 2025

View reviewed changes

packages/std/src/query/mod.rs Outdated Show resolved Hide resolved

packages/vm/src/instance.rs Outdated Show resolved Hide resolved

chore: Use Binary instead of Checksum

93fe55d

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch 2 times, most recently from 3d1a741 to 94a30fb Compare May 13, 2025 14:26

chore: Move impl_hidden_constructor macro to lib.rs

4ef6621

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch from 94a30fb to 4ef6621 Compare May 13, 2025 14:27

kulikthebird requested review from chipshort and webmaster128 May 13, 2025 14:49

chipshort reviewed May 14, 2025

View reviewed changes

packages/std/src/lib.rs Outdated Show resolved Hide resolved

packages/std/src/lib.rs Outdated Show resolved Hide resolved

kulikthebird and others added 3 commits May 14, 2025 13:11

chore: Update Changelog

615cee8

[autofix.ci] apply automated fixes

4d14169

chore: Move the macro to utils module

2fbdb6a

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch from 7801b00 to 2fbdb6a Compare May 14, 2025 11:12

kulikthebird requested a review from chipshort May 14, 2025 11:13

webmaster128 reviewed May 14, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

packages/std/src/testing/mock.rs Outdated Show resolved Hide resolved

packages/std/src/types.rs Outdated Show resolved Hide resolved

Update CHANGELOG.md

3deb9ad

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

kulikthebird changed the title ~~feat: Add Tx checksum to TransactionInfo and make it non exhaustive~~ feat: Add Tx hash to TransactionInfo and make it non exhaustive May 14, 2025

kulikthebird and others added 2 commits May 14, 2025 15:03

chore: Update after review

669875a

[autofix.ci] apply automated fixes

22173cd

webmaster128 reviewed May 14, 2025

View reviewed changes

packages/std/src/binary.rs Outdated Show resolved Hide resolved

webmaster128 reviewed May 14, 2025

View reviewed changes

kulikthebird and others added 6 commits May 14, 2025 15:33

Update packages/vm/src/testing/mock.rs

4dd08e9

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Update packages/vm/src/testing/mock.rs

9330907

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Update packages/std/src/testing/mock.rs

e6e3eb1

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Update packages/std/src/testing/mock.rs

d82b5ed

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Update packages/std/src/types.rs

5426fc5

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Update packages/std/src/types.rs

f7f784a

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch from 24b6b44 to 6fa5775 Compare May 14, 2025 13:37

chore: Update after review

6a4d45b

kulikthebird force-pushed the tkulik/chore/transaction_info_non_exhaustive branch from a2fbc31 to 6a4d45b Compare May 14, 2025 13:46

webmaster128 approved these changes May 14, 2025

View reviewed changes

autofix-ci bot and others added 2 commits May 14, 2025 13:54

[autofix.ci] apply automated fixes

acf03ca

chore: Add test for hex encoding

12e4903

kulikthebird merged commit 75a130a into main May 14, 2025
42 checks passed

kulikthebird deleted the tkulik/chore/transaction_info_non_exhaustive branch May 14, 2025 17:04

kulikthebird mentioned this pull request May 16, 2025

feat: Add support for IBCv2 Send entry point CosmWasm/wasmd#2252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add Tx hash to TransactionInfo and make it non exhaustive #2480

feat: Add Tx hash to TransactionInfo and make it non exhaustive #2480

kulikthebird commented May 13, 2025

Uh oh!

Uh oh!

webmaster128 commented May 13, 2025

Uh oh!

kulikthebird commented May 13, 2025

Uh oh!

chipshort commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webmaster128 May 14, 2025

Uh oh!

Uh oh!

Uh oh!

webmaster128 left a comment

Uh oh!

Uh oh!

Uh oh!

feat: Add Tx hash to TransactionInfo and make it non exhaustive #2480

feat: Add Tx hash to TransactionInfo and make it non exhaustive #2480

Conversation

kulikthebird commented May 13, 2025

Uh oh!

Uh oh!

webmaster128 commented May 13, 2025

Uh oh!

kulikthebird commented May 13, 2025

Uh oh!

chipshort commented May 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webmaster128 May 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webmaster128 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!