-
Notifications
You must be signed in to change notification settings - Fork 373
feat: Add support for IBCv2 Send entry point #2477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9cac276
to
287243a
Compare
d1409e6
to
38f0933
Compare
b36f7e5
to
48cd99b
Compare
48cd99b
to
bf4cf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a typo
packages/std/src/ibc2.rs
Outdated
/// Ibc2PacketSendMsg represents a payload sent event in the IBC2 protocol. | ||
/// Since sending IBCv2 packet is permissionless, the IBC protocol indtroduces | ||
/// an extra entry point, in which the application can verify the message sent from | ||
/// a port ID belonging to the contract. | ||
/// | ||
/// It includes details about the source and destination clients, the sequence | ||
/// number of the packet and the signer that sent the message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice doc comment! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🦸
#[strum(serialize = "ibc2_packet_send")] | ||
Ibc2PacketSend, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, looks like we forgot to add the ack entrypoint here. Not related to this PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added that in this PR, good catch!
Co-authored-by: Christoph Otter <chris@confio.gmbh>
No description provided.