Skip to content

feat: Add support for IBCv2 Send entry point #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

kulikthebird
Copy link
Member

No description provided.

@kulikthebird kulikthebird force-pushed the tkulik/feat/ibc2_sent_entrypoint branch from 9cac276 to 287243a Compare May 12, 2025 09:48
@kulikthebird kulikthebird changed the title feat: Add support for IBCv2 Sent entry point feat: Add support for IBCv2 Send entry point May 12, 2025
@kulikthebird kulikthebird force-pushed the tkulik/feat/ibc2_sent_entrypoint branch 3 times, most recently from d1409e6 to 38f0933 Compare May 12, 2025 12:12
@kulikthebird kulikthebird linked an issue May 12, 2025 that may be closed by this pull request
@kulikthebird kulikthebird force-pushed the tkulik/feat/ibc2_sent_entrypoint branch 3 times, most recently from b36f7e5 to 48cd99b Compare May 12, 2025 15:23
@kulikthebird kulikthebird marked this pull request as ready for review May 12, 2025 15:24
@kulikthebird kulikthebird requested a review from chipshort May 12, 2025 15:24
@kulikthebird kulikthebird force-pushed the tkulik/feat/ibc2_sent_entrypoint branch from 48cd99b to bf4cf35 Compare May 12, 2025 15:24
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a typo

Comment on lines 164 to 170
/// Ibc2PacketSendMsg represents a payload sent event in the IBC2 protocol.
/// Since sending IBCv2 packet is permissionless, the IBC protocol indtroduces
/// an extra entry point, in which the application can verify the message sent from
/// a port ID belonging to the contract.
///
/// It includes details about the source and destination clients, the sequence
/// number of the packet and the signer that sent the message.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc comment! 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🦸

Comment on lines +44 to +45
#[strum(serialize = "ibc2_packet_send")]
Ibc2PacketSend,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks like we forgot to add the ack entrypoint here. Not related to this PR though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added that in this PR, good catch!

@kulikthebird kulikthebird merged commit aa24a8f into main May 12, 2025
40 checks passed
@kulikthebird kulikthebird deleted the tkulik/feat/ibc2_sent_entrypoint branch May 12, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: ibc_sent entrypoint in CosmWasm
2 participants