Skip to content

Implement downcasting for Api trait #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2025
Merged

Implement downcasting for Api trait #2383

merged 4 commits into from
Feb 19, 2025

Conversation

chipshort
Copy link
Collaborator

closes #2157

aumetra
aumetra approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. To verify my assumption here based on the ticket you linked: this is so one can use the addr_make function of MockApi when passed through &dyn Api, right?

@chipshort
Copy link
Collaborator Author

Yes, that's exactly the point. the test I wrote here showcases that.

@aumetra
Copy link
Member

aumetra commented Feb 19, 2025

Well, then let's add a Changelog entry and merge that :P

@chipshort chipshort merged commit 1ca93a4 into main Feb 19, 2025
17 of 39 checks passed
@chipshort chipshort deleted the co/downcast-api branch February 19, 2025 10:52
@chipshort chipshort mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CosmWasm 2 address systems flaws
2 participants
@chipshort @aumetra