-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide native way to cast deps to empty #1813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start, thanks. Some thoughts here:
- to -> into
- is
into_empty
a good name? Ideas @chipshort? - We need doc comments for the new functions to help contract developers understand what this does and if they should use it.
70bf8aa
to
eb3478b
Compare
3f96a92
to
17f7011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM. Could you add a brief CHANGELOG entry to the Unreleased section in CHANGELOG.md?
c298e1c
to
5741162
Compare
closes #1812