Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k256 to 0.13.1 #1800

Merged
merged 4 commits into from
Jul 31, 2023
Merged

Upgrade k256 to 0.13.1 #1800

merged 4 commits into from
Jul 31, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1789

The key recovery api changed a bit and seems to support RecoveryId 3 now, so I'm erroring manually in that case.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In RustCrypto/signatures#392 it is explained that the values 2 and 4 are not needed for ECDSA+secp256k1 but for ECDSA+other curves. The secp256k1 specific implementation was removed:

ecdsa::recoverable module; see documentation for replacements (RustCrypto/elliptic-curves#675)

#1803 just refactors away the .unwrap() but is otherwise doing the same thing.

@chipshort chipshort merged commit d5eaa62 into main Jul 31, 2023
3 checks passed
@chipshort chipshort deleted the 1789-upgrade-k256 branch July 31, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade k256 to 0.13
2 participants