Skip to content

Run check_contract on every wasm file. #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

jawoznia
Copy link
Contributor

Instead of passing wildcard to script CI will find
every wasm file and run check_contract on it.

Instead of passing wildcard to script CI will find
every wasm file and run check_contract on it.
@uint
Copy link
Contributor

uint commented Aug 17, 2022

That works. For context: this is because check_contract.rs doesn't really support wildcard parameters.

@webmaster128
Copy link
Member

But isn't the glob expanded by bash, not the tool itself. We use export GLOBIGNORE="../../artifacts/floaty.wasm" here, which works. So I expect the tool to see a list of arguments.

@uint
Copy link
Contributor

uint commented Aug 17, 2022

But isn't the glob expanded by bash, not the tool itself. We use export GLOBIGNORE="../../artifacts/floaty.wasm" here, which works. So I expect the tool to see a list of arguments.

I think you're right. I think the problem is the tool expects to only get one path, not several. It does error when you attempt a glob with more than one .wasm artifact.

@webmaster128
Copy link
Member

webmaster128 commented Aug 17, 2022

Okay, cool. In this case we need to tell the find tool to exclude floaty.wasm.

@jawoznia
Copy link
Contributor Author

Script will now ignore floaty.wasm.

@jawoznia jawoznia merged commit af3ed17 into main Aug 17, 2022
@jawoznia jawoznia deleted the multiple_wasm_check_contract_call branch August 17, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants