Implement PartialEq for references on all math types - LHS and tests #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1190
to
+1191
| Uint512::from(lhs as u64), | ||
| Uint512::from(rhs as u64), |
There was a problem hiding this comment.
This creates signed ints and then unsafely casts them to u64, right? Can you use 1u64 literals instead?
There was a problem hiding this comment.
Yeah, can do, just thought this was less verbose
There was a problem hiding this comment.
I got scared of unsafe casts after seeing a some bug in a TypeScript app that popped up on the user's machine but could have been cought at compile time.
There was a problem hiding this comment.
Is there something like Uint512::from<u64>(lhs) for multiple versions of a trait implementation, even if from is not generic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds things to #1350:
PartialEqimplementation for when LHS operand is a reference