-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k256 #1374
Bump k256 #1374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes depends on paragraph from digest
CHANGELOG:
https://github.com/RustCrypto/traits/blob/master/digest/CHANGELOG.md#changed-1
Dirty traits are removed and instead block-level traits are introduced. Variable output traits reworked and now support both run and compile time selection of output size.
right?
I'd only ask you to update our CHANGELOG with entry about bumping k256
and digest
to appropriate versions.
Yes, that and a function rename. I've updated the CHANGELOG as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for contribution.
@ueco-jb any plans on release a new version of this soon? like |
@shekohex I think right now we are quite close to releasing 1.1.0. |
Looking at RustCrypto/signatures#409 (comment) and RustCrypto/utils#723 the core of this issue seems to be a MSRV problem, which causes ecdsa 0.13 and 0.14 being impossible to install in one project. This is very unfortunate but also not our bug. So I am hesitant to squeeze out a cosmwasm 1.0.1 patch release for that, especially given the non-trivial diff here (thank you by the way). I think using latest master for your development and switching to 1.1.0 once it is out is a reasonable strategy. |
Sounds good, thank you @webmaster128 and @ueco-jb ! |
cosmrs 0.8 release bumped
k256
, which makescargo
unable to select compatible versions forsignature
dependency crate when buildingcosmwasm-std
andcosmrs
together.This PR also bumps
k256
dependency with what should be minimal effect oncosmwasm-crypto
[1] to remove the said incompatibility.[1] k256 CHANGELOG: https://github.com/RustCrypto/elliptic-curves/blob/master/k256/CHANGELOG.md