Add optional download sub-directory #58 #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added directory option to the options page * This is a subdirectory of the default Chrome download directory * Integrated the download directory option into the download function
# Conflicts: # source/options.js
- made the download dir input a bit smaller so that it better fits in with the rest of the options. - since 2.4.0 is not actually officially released, no need for a version bump here - also finally moved the options page and its dependencies into a separate dir, further cleanups are definitely necessary in the future
Owner
|
Thank you! Sorry for being unresponsive recently. Finally merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an optional sub-directory to be defined on the options page.