You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @Daniele-Cangi, tests are absolutely welcomed! The first three points are great to implement. I'm finishing the service cache feature in #216 so it would be great not to touch the metadata and service-cache/service-discovery files. Please make sure to send the PR to the 0.1.5 branch. In case you have any question you can ping me here or you can send me an email!
Hi @Daniele-Cangi , I've merged PR #216 in case you want to continue working on this issue! Right now I'm pushing the cortexbrain-common@0.1.4 to the crates.io registries
Hi Lorenzo, following #217 and your invitation to continue on #198, I'm taking a second small test-only slice against 0.1.5: hermetic contract tests for cortexbrain-common OpenTelemetry metric recording using synthetic events and an in-memory reader. I'll keep Docker, Kubernetes, root, loaded eBPF programs, and metadata/service-discovery changes out of scope. I also noticed the record_enter_mem_alloc documentation disagrees with its events_total increment; I'll surface that in the PR rather than silently changing behavior. Please let me know if you prefer a different boundary.
Activity
Daniele-Cangi commentedon Sep 2, 2026
Hi Lorenzo,
I reviewed #198 together with the current cortexbrain-common feature layout and
would like to contribute a small, hermetic first slice.
Proposed scope:
combinations;
SslEvent Pod implementation currently not gated by monitoring-structs;
protocol conversion and address conversion;
The PR would reference #198 and #158 without attempting to close either umbrella
issue.
Please confirm that this focused scope is aligned with the current direction.
LorenzoTettamanti commentedon Sep 2, 2026
Hi @Daniele-Cangi, tests are absolutely welcomed! The first three points are great to implement. I'm finishing the service cache feature in #216 so it would be great not to touch the metadata and service-cache/service-discovery files. Please make sure to send the PR to the 0.1.5 branch. In case you have any question you can ping me here or you can send me an email!
Daniele-Cangi commentedon Sep 2, 2026
perfect I'll start working on it right away!
[#198]: add common feature isolation and contract tests
[#198]: add common feature isolation and contract tests
LorenzoTettamanti commentedon Sep 10, 2026
Hi @Daniele-Cangi , I've merged PR #216 in case you want to continue working on this issue! Right now I'm pushing the cortexbrain-common@0.1.4 to the crates.io registries
siddh34 commentedon Sep 14, 2026
Hey guys picking up with CLI tests. I will submit my PR next week!
18 remaining items
[CortexFlow#198]: use command runner downstream & tests
[CortexFlow#198]: add CLI tests and update test file names for clarity
[#198]: Command runner impl
[#198]: use command runner downstream & tests
[#198]: add CLI tests and update test file names for clarity
[#198]: refactor & enhance install logic and add new dependencies for…
[#198]: use command runner downstream & tests
[#198]: add CLI tests and update test file names for clarity
[#198]: use command runner downstream & tests
[#198]: add CLI tests and update test file names for clarity
[#198]: use command runner downstream & tests
[#198]: add CLI tests and update test file names for clarity
Daniele-Cangi commentedon Oct 2, 2026
Hi Lorenzo, following #217 and your invitation to continue on #198, I'm taking a second small test-only slice against 0.1.5: hermetic contract tests for cortexbrain-common OpenTelemetry metric recording using synthetic events and an in-memory reader. I'll keep Docker, Kubernetes, root, loaded eBPF programs, and metadata/service-discovery changes out of scope. I also noticed the record_enter_mem_alloc documentation disagrees with its events_total increment; I'll surface that in the PR rather than silently changing behavior. Please let me know if you prefer a different boundary.
[#198]: add hermetic OpenTelemetry metric contract tests
LorenzoTettamanti commentedon Oct 3, 2026
@Daniele-Cangi everything is working fine! Thanks!