ResponseSender - Replace default headers #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donatj
force-pushed
the
fix/ReplaceDefaultHeaders
branch
from
c1c5e3b to
c5f3e47
Compare
As written, ResponseSender would not overwrite default headers. This changes the default behaviour to overwrite default headers
donatj
force-pushed
the
fix/ReplaceDefaultHeaders
branch
from
c5f3e47 to
29979a3
Compare
donatj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, ResponseSender would not overwrite default headers, which was extremely limiting for cases of things such as cache headers and
X-Powered-ByThis changes the default behaviour to overwrite default headers