Backend Todo1 #11
Open
Backend Todo1 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierlyu
reviewed
Oct 28, 2020
| const wallet=new Wallet(req.body.senderPrivateKey); | ||
| const trans=new Transaction(); | ||
| trans.newTransaction(wallet, req.body.recipientPublicKey, req.body.amount); | ||
| const bc=Blockchain(Block.genesis()); |
Contributor
There was a problem hiding this comment.
first it should be new Blockchain(...) and also it should not be initalized to genesis block. It should query the MySQL database and initalize the Blockchain object with the data fetched from the db
Contributor
|
First of all, the PR and the commits should be named properly and more descriptive, such as "added ... feature" or "updated ... to ....". Also, make sure you pull from master first before making any changes. It looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.