Repository navigation
feat: add CloudWatch observability and operational alarms - #21
CoreyLeath-code merged 7 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0df3deaf3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name = "NotificationProcessingFailures" | ||
| namespace = local.observability_namespace |
There was a problem hiding this comment.
Isolate the failure metric per deployment
When multiple stacks with different name_prefix values run in the same AWS account and region, every metric filter publishes into the identical namespace/name pair with no dimensions. CloudWatch therefore aggregates all environments into one time series, so a record failure in a development stack can trigger the production stack's alarm and appear on its dashboard. Include the deployment prefix in the metric identity or add a per-stack dimension, and use the same identity in the alarm and dashboard.
Useful? React with 👍 / 👎.
bd33545
into
feat/aws-lambda-event-pipeline
Summary
Adds a Terraform-managed CloudWatch observability layer on top of the AWS Lambda event-processing extension.
This is a stacked PR based on
feat/aws-lambda-event-pipelineso the serverless implementation and observability changes remain independently reviewable.What changed
Errorsmetric when using SQS partial-batch responses.operational-alertsSNS topic separate from product-facing ride notifications.alarm_emailTerraform variable; AWS subscription confirmation is still required before email delivery begins.Design choices
AWS/LambdaandAWS/SQSmetrics instead of duplicating standard telemetry with custom metrics.Validation
Expected checks:
fmt -check -recursiveinit -backend=falsevalidateProduction boundary
This PR adds deployable monitoring and alerting resources, not evidence of a live production SRE program. A production deployment still needs measured SLIs/SLOs, paging severity and escalation policy, tracing, idempotent DLQ replay, PII-safe logging controls, cost budgets, and operational ownership.