runnable pollers splitting #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Split the class RunnablePoller into 3 classes:
WorkflowRunnablePoller, EventRunnablePoller, CommandRunnablePoller
Why this change ?
In order to optimize the system, we need to poll only the commands every 10 seconds.
The workflow and the events are polled only once at the service startup.
Describe your implementation or design
The class RunnablePoller is split into 3 classes : WorkflowRunnablePoller, EventRunnablePoller, CommandRunnablePoller
The interval for each of those pollers can now be configured independently via 3 options: PollWorkflowsInterval, PollEventsInterval, PollCommandsInterval. The option PollInterval does not exist anymore.
Tests
No
Breaking change
Yes
the option PollInterval has been replaced by PollWorkflowsInterval, PollEventsInterval and PollCommandsInterval
the extension method UsePollInterval has been replaced by UsePollWorkflowsInterval, UsePollEventsInterval, and UsePollCommandsInterval