This repository was archived by the owner on Jul 2, 2023. It is now read-only.
Open
Conversation
added 15 commits
February 13, 2016 22:44
Owner
|
@bencer thank you for the pull request, I will be adding notes of the next couple weeks as I have time to review and test. Also thank you for such a well documented and easily reviewable pull request :). |
Owner
|
@bencer I have reviewed the pull request. I really like most of what your doing. I have a few questions, and a few comments. I think the README.md needs to be updated with some examples and additional documentation. At the very least I feel a basic draft with your additions needs to be added before I merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@CorbanR, let me know what do you think about these changes, I've tried to keep each change in different commits so its easy to discuss them independently.