Skip to content

Guard refresh wait nudge during compile #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 1 commit into from
Jan 15, 2026
Merged

Guard refresh wait nudge during compile #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions MCPForUnity/Editor/Tools/RefreshUnity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ public static async Task<object> HandleCommand(JObject @params)
{
try
{
await WaitForUnityReadyAsync(TimeSpan.FromSeconds(DefaultWaitTimeoutSeconds)).ConfigureAwait(true);
await WaitForUnityReadyAsync(
TimeSpan.FromSeconds(DefaultWaitTimeoutSeconds),
allowNudge: !compileRequested).ConfigureAwait(true);
}
catch (TimeoutException)
{
Expand Down Expand Up @@ -126,7 +128,7 @@ public static async Task<object> HandleCommand(JObject @params)
});
}

private static Task WaitForUnityReadyAsync(TimeSpan timeout)
private static Task WaitForUnityReadyAsync(TimeSpan timeout, bool allowNudge)
{
var tcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
var start = DateTime.UtcNow;
Expand Down Expand Up @@ -165,8 +167,11 @@ void Tick()
}

EditorApplication.update += Tick;
// Nudge Unity to pump once in case update is throttled.
try { EditorApplication.QueuePlayerLoopUpdate(); } catch { }
if (allowNudge)
{
// Nudge Unity to pump once in case update is throttled.
try { EditorApplication.QueuePlayerLoopUpdate(); } catch { }
}
return tcs.Task;
}
}
Expand Down