-
Notifications
You must be signed in to change notification settings - Fork 693
Payload-safe paging for hierarchy/components + safer asset search + docs #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dsarno
merged 19 commits into
CoplayDev:main
from
dsarno:improve-get-hierarchy-and-get-components
Dec 29, 2025
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e515655
Fix test teardown to avoid dropping MCP bridge
dsarno ca4c830
Avoid leaking PlatformService in CodexConfigHelperTests
dsarno 2e480c0
Fix SO MCP tooling: validate folder roots, normalize paths, expand te…
dsarno 1e7abb3
Remove UnityMCPTests stress artifacts and ignore Assets/Temp
dsarno a117c64
Ignore UnityMCPTests Assets/Temp only
dsarno c8907ac
Clarify array_resize fallback logic comments
dsarno 14ff22a
Refactor: simplify action set and reuse slash sanitization
dsarno 6b76817
Enhance: preserve GUID on overwrite & support Vector/Color types in S…
dsarno 39c73cb
Fix: ensure asset name matches filename to suppress Unity warnings
dsarno 64a3bc6
Fix: resolve Unity warnings by ensuring asset name match and removing…
dsarno cc9b9a3
Refactor: Validate assetName, strict object parsing for vectors, remo…
dsarno 553ef26
Hardening: reject Windows drive paths; clarify supported asset types
dsarno 7bb6543
Delete FixscriptableobjecPlan.md
dsarno b20c3f0
Paginate get_hierarchy and get_components to prevent large payload cr…
dsarno dc3c72d
dev: add uvx dev-mode refresh + safer HTTP stop; fix server typing eval
dsarno 4045d5a
Payload-safe paging defaults + docs; harden asset search; stabilize C…
dsarno b18cd93
chore: align uvx args + coercion helpers; tighten safety guidance
dsarno 2482801
chore: minor cleanup + stabilize EditMode SO tests
dsarno 9aa02d2
Merge upstream/main into improve-get-hierarchy-and-get-components
dsarno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): The netstat-based PID parsing on Windows doesn’t distinguish LISTENING entries from client connections.
On Windows,
netstat -ano | findstr :{port}returns both LISTENING and ESTABLISHED (and other) entries. The current logic takes the PID from any matching line, so it can capture client processes instead of the actual listener, even thoughLooksLikeMcpServerProcessreduces this somewhat. Please restrict PID collection to LISTENING lines only (e.g., filter by state in code or addfindstr LISTENING), so you only return PIDs for listening sockets on that port.Suggested implementation:
If the netstat invocation is constructed elsewhere (e.g., as
"netstat -ano | findstr :{port}"), you could further harden this by adding aLISTENINGfilter at the shell level, such as"netstat -ano | findstr :{port} | findstr LISTENING". That change would need to be applied where the process start info/command line for netstat is built.