Fix version label + use secure unity version #321

msanatan · 2025-10-17T17:03:49Z

We also fix the version label in the new UI

Summary by CodeRabbit

Chores
- Updated build and test workflows to use Unity 2021.3.45f2
- Updated test project metadata to match new Unity version
UI Improvements
- Settings panel now displays the package version dynamically

Older Unity version had the security vulnerability, so we update it

… workflow" This reverts commit a6ab3d9.

…activator

…using built-in license handling

…built-in activation flow

…nse in the long-running container Now we got the license secret to be read, we got this error: "Machine bindings don't match". So it seems that the license I generated locally can't be used. So we need to activate the license within the container

…the license in the long-running container" This reverts commit f6a9aa6.

…image's built-in activation flow" This reverts commit a9f4c02.

…ion and using built-in license handling" This reverts commit 4e5ffc0.

…i/unity-activator" This reverts commit e9520ee.

…I workflow" This reverts commit 01b8879.

coderabbitai · 2025-10-17T17:04:10Z

Walkthrough

Unity version bumped from 2021.3.45f1 to 2021.3.45f2 across CI/CD workflows and project settings. Added a version label UI element to the editor window to display the package version dynamically.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Version Updates `.github/workflows/claude-nl-suite.yml`, `.github/workflows/unity-tests.yml`	Updated Unity editor image and test matrix version from 2021.3.45f1 to 2021.3.45f2.
Project Metadata Version Update `TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt`	Updated editor version metadata from 2021.3.45f1 to 2021.3.45f2 with new revision hash.
Editor Window Version Label `MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs`, `MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml`	Added UI element to display package version dynamically in Settings window; wired up label reference and populated with `AssetPathUtility.GetPackageVersion()`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Set up Unit tests #220: Concurrent update to unity-tests.yml and ProjectVersion.txt with identical version bump (2021.3.45f1 → 2021.3.45f2).
Adjust the package before publishing on OpenUPM #219: Related workflow and CI metadata version updates affecting Unity editor image references.

Suggested reviewers

dsarno

Poem

🐰 A version grows from one to two,
The Unity editor gets renewed,
With labels bright for all to see,
The package version runs so free—
From five-point-oh in settings' view,
Our little updates now come true! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "Use secure unity version" is directly related to the primary change in the pull request, which is updating the Unity version from 2021.3.45f1 to 2021.3.45f2 across multiple configuration files and project settings. The changes clearly demonstrate version bumps in the workflows and project metadata. While the PR also includes a secondary change to the version label UI (as indicated by "also fixes" in the description), the title appropriately focuses on the main objective. The title is concise, readable, and specific enough that a teammate scanning the history would understand that the primary change involves upgrading to a patched Unity version.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c00294 and 0778e7c.

📒 Files selected for processing (5)

.github/workflows/claude-nl-suite.yml (1 hunks)
.github/workflows/unity-tests.yml (1 hunks)
MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs (3 hunks)
MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml (1 hunks)
TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt (1 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs (1)

MCPForUnity/Editor/Helpers/AssetPathUtility.cs (2)

AssetPathUtility (13-161)

GetPackageVersion (142-160)

🔇 Additional comments (7)

TestProjects/UnityMCPTests/ProjectSettings/ProjectVersion.txt (1)

1-2: LGTM!

The Unity project version metadata update is consistent with the workflow changes and correctly reflects the version bump to 2021.3.45f2.

MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.uxml (1)

12-12: LGTM!

Changing the hardcoded version string to a placeholder "..." is a good practice. The version will be dynamically populated by the C# code using AssetPathUtility.GetPackageVersion(), which correctly reads from the package.json file.

MCPForUnity/Editor/Windows/MCPForUnityEditorWindowNew.cs (3)

27-27: LGTM!

The addition of the versionLabel field follows the established pattern for UI element references in this class.

195-195: LGTM!

Caching the version label UI element is consistent with how other UI elements are retrieved in this method.

245-245: LGTM!

The initialization properly sets the version label text using AssetPathUtility.GetPackageVersion(), which gracefully returns "unknown" if the version cannot be determined. This replaces the hardcoded "5.0.0" in the UXML with a dynamically fetched value.

.github/workflows/unity-tests.yml (1)

23-23: Code changes verified: Unity 2021.3.45f2 is confirmed as a security patch.

Unity 2021.3.45f2 was released Oct 3, 2025 as a security-patched LTS release addressing CVE‑2025‑59489 (unsafe file-loading / local file inclusion vulnerability). The version bump is appropriate and justified by this security fix.

.github/workflows/claude-nl-suite.yml (1)

14-14: Unity CI Docker image verified.

The unityci/editor image tag ubuntu-2021.3.45f2-linux-il2cpp-3 exists and is available through GameCI on Docker Hub. The configuration change is correct and the image can be successfully pulled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

* chore: update Unity version from 2021.3.45f1 to 2021.3.45f2 Older Unity version had the security vulnerability, so we update it * feat: add dynamic version display in editor window settings * refactor: remove manual license file handling from Unity test workflow * Revert "refactor: remove manual license file handling from Unity test workflow" This reverts commit a6ab3d9. * feat: add Unity license credentials to Docker containers in CI workflow * refactor: replace manual Unity license activation with game-ci/unity-activator * refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling * fix: improve Unity license activation in CI by using unityci image's built-in activation flow * refactor: activate once in a temporary container, then reuse the license in the long-running container Now we got the license secret to be read, we got this error: "Machine bindings don't match". So it seems that the license I generated locally can't be used. So we need to activate the license within the container * Revert "refactor: activate once in a temporary container, then reuse the license in the long-running container" This reverts commit f6a9aa6. * Revert "fix: improve Unity license activation in CI by using unityci image's built-in activation flow" This reverts commit a9f4c02. * Revert "refactor: simplify Unity CI setup by removing game-ci activation and using built-in license handling" This reverts commit 4e5ffc0. * Revert "refactor: replace manual Unity license activation with game-ci/unity-activator" This reverts commit e9520ee. * Revert "feat: add Unity license credentials to Docker containers in CI workflow" This reverts commit 01b8879.

msanatan added 14 commits October 14, 2025 21:42

chore: update Unity version from 2021.3.45f1 to 2021.3.45f2

f5d56de

Older Unity version had the security vulnerability, so we update it

feat: add dynamic version display in editor window settings

ba35a47

refactor: remove manual license file handling from Unity test workflow

a6ab3d9

Revert "refactor: remove manual license file handling from Unity test…

87c45ff

… workflow" This reverts commit a6ab3d9.

feat: add Unity license credentials to Docker containers in CI workflow

01b8879

refactor: replace manual Unity license activation with game-ci/unity-…

e9520ee

…activator

refactor: simplify Unity CI setup by removing game-ci activation and …

4e5ffc0

…using built-in license handling

fix: improve Unity license activation in CI by using unityci image's …

a9f4c02

…built-in activation flow

Revert "refactor: activate once in a temporary container, then reuse …

0708ace

…the license in the long-running container" This reverts commit f6a9aa6.

Revert "fix: improve Unity license activation in CI by using unityci …

e08779e

…image's built-in activation flow" This reverts commit a9f4c02.

Revert "refactor: simplify Unity CI setup by removing game-ci activat…

b5bec1b

…ion and using built-in license handling" This reverts commit 4e5ffc0.

Revert "refactor: replace manual Unity license activation with game-c…

172d7fd

…i/unity-activator" This reverts commit e9520ee.

Revert "feat: add Unity license credentials to Docker containers in C…

0778e7c

…I workflow" This reverts commit 01b8879.

msanatan self-assigned this Oct 17, 2025

msanatan merged commit 90911aa into CoplayDev:main Oct 17, 2025
1 check passed

msanatan deleted the fix/use-secure-unity-version branch October 17, 2025 17:35

msanatan changed the title ~~Use secure unity version~~ Fix version label + use secure unity version Oct 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix version label + use secure unity version #321

Fix version label + use secure unity version #321

Uh oh!

msanatan commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Fix version label + use secure unity version #321

Fix version label + use secure unity version #321

Uh oh!

Conversation

msanatan commented Oct 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

msanatan commented Oct 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 17, 2025 •

edited

Loading