Repository navigation
Reduce dots() N+1 queries to a single batch fetch - #146
Open
OpenGithubs wants to merge 1 commit into
Open
OpenGithubs wants to merge 1 commit into
OpenGithubs wants to merge 1 commit into
Conversation
Previously dots() issued one dot_spaces SELECT per dot (N+1 pattern). Now fetches all dot_spaces rows once and groups them in memory via a Map. With 10 dots this cuts 11 DB round-trips down to 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance optimization:
WorkspaceStore.dots()used an N+1 query pattern — oneSELECT * FROM dotsfollowed by oneSELECT spaceId FROM dot_spaces WHERE dotId=?per dot. With N dots that is N+1 database round-trips just to list the workspace. Now fetches alldot_spacesrows once and groups them in memory with a Map.Changes
src/server/workspace.ts: batch fetch dot_spaces, group in-memory, cut N+1 round-trips down to 2.Commits
perf-dots-joinperf: reduce dots() N+1 queries to a single batch fetch