Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algos first introductory assignment #213

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

isaiahrivera21
Copy link
Contributor

Hey guys this the first assignment I would want for a freshman joining algos to be able to do. Would appreciate some feedback about what is unclear about this assignment.

Copy link
Member

@jacobkoziej jacobkoziej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the initiative to start writing documentation!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we already track PNG files with Git LFS in the repo. Please ammend this commit to remove the binary file and configure Git LFS properly on your machine.


## Introduction

The supplementary python material is so that you’re familiar with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The supplementary python material is so that you’re familiar with the
The supplementary Python material is so that you’re familiar with the

Comment on lines +6 to +8
language itself. This tutorial is to learn about one specific library
this team utilizes often: OpenCV and a common sensor we use in our
projects: stereo camera.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... learn how to utilize OpenCV with a stereo camera for blob detection."

Why do we use a stereo camera?

The primary reason is for depth estimation. Let’s say there is a human
standing in the road and we want to stop before we hit him. You can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
standing in the road and we want to stop before we hit him. You can
standing in the road and we want to stop before we hit them. You can

Please try to be gender neutral.

this team utilizes often: OpenCV and a common sensor we use in our
projects: stereo camera.

Why do we use a stereo camera?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Why do we use a stereo camera?
*Why do we use a stereo camera?*

the target (the big green circle). It is highly recommended you use
[this function](https://learnopencv.com/blob-detection-using-opencv-python-c/):

![Image](./algos_a1.d/AL_OpenCv_A1_Image.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give a descriptive image caption.


**Helpful Info**:

- The ZED cameras can be found in room 701.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave this out as it's not applicable outside of our lab for others to make use of.

- [How to use OpenCV with the ZED](https://www.stereolabs.com/docs/opencv/python)
- [Depth Stabilization Parameters](https://www.stereolabs.com/docs/depth-sensing/depth-settings)

*P3*: Once you are detecting the proper shape and the distance from it,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would turn each problem into an appropriate markdown heading.

to the object. Report the percent error of the true distance (tape
measurer) and the estimated distance (your answer from P2).

**Note**: Note: If the ZED is giving inaccurate readings that is because
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: Note: If the ZED is giving inaccurate readings that is because
**Note:** If the ZED is giving inaccurate readings that is because

Also check to see if mdBook has a proper note block, if not, lets markdown quote indent this.

Comment on lines +78 to +81
**Note**: Note: If the ZED is giving inaccurate readings that is because
it has a falloff in accuracy at close ranges so try moving the image
back.
https://support.stereolabs.com/hc/en-us/articles/206953039-How-does-the-ZED-work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: Note: If the ZED is giving inaccurate readings that is because
it has a falloff in accuracy at close ranges so try moving the image
back.
https://support.stereolabs.com/hc/en-us/articles/206953039-How-does-the-ZED-work
**Note**: Note: If the ZED is giving inaccurate readings that is because
it has a falloff in accuracy at close ranges so try moving the image
back.
<https://support.stereolabs.com/hc/en-us/articles/206953039-How-does-the-ZED-work>

I'd also rather you properly give the link a name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants