CSSTUDIO-1660 replaced TimeRangeDialog with popover implementation in DataBrowser #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjenkscybercom
changed the title
…h static factory method
georgweiss
reviewed
May 6, 2022
There was a problem hiding this comment.
Functionality seems to be in place.
However, the UI element to which the PopOver is "pointing" differs between the Time Axis tab and the export tab. I prefer the way it works in the export tab, i.e. point to the button launching the PopOver. Currently in the Time Axis tab the PopOver points to the End Time label, which is a bit misleading and confusing.
Also, clicking Apply should dismiss the PopOver to save the user from an extra button click.
…y dismisses popover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FXML would have been nice, however the TimeRelativeIntervalPane etc are all dynamic Java nodes. It would have been a moderate-to-sizable chunk of work to convert those to FXML.
So, this implementation merely tacks on the Apply and Close buttons to the existing TimeRelativeIntervalPane and provides a means to define the behavior of those buttons in callbacks.