Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in ActionButton widget #2201

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Minor fixes in ActionButton widget #2201

merged 2 commits into from
Apr 8, 2022

Conversation

georgweiss
Copy link
Collaborator

If user marks ActionButton as disabled and then edits the associated actions, the enabled state reverts back to "enabled" when user dismisses the actions dialog.

This PR fixes the issue.

Additionally:

  • Cursor changes not applied in edit mode when widget is marked as disabled. Found it a bit confusing and not very useful to see the "not writable" cursor in while editing the OPI.
  • Some dead code removed.

@georgweiss georgweiss requested a review from kasemir April 4, 2022 07:36
@georgweiss
Copy link
Collaborator Author

@kasemir, can you please add your input?

@kasemir
Copy link
Collaborator

kasemir commented Apr 7, 2022

I did, see earlier 'review' comment.
The empty attachTooltip() needs to remain.
If you remove it, we fall back to the default which adds a tooltip to the jfx_node, a "Pane", but we already attach a tooltip to the actual button in makeBaseButton(), so you get two tool tips.
Leave attachTooltip() {} as it was to only get the one correct tool tip on the Button.

@kasemir
Copy link
Collaborator

kasemir commented Apr 7, 2022

This is what I had tried to point out a few days ago, not sure if "pending" means it doesn't show up?

Screen Shot 2022-04-07 at 10 02 09 AM

@georgweiss
Copy link
Collaborator Author

Precisely, cannot see the review comment.

In any case, will put back attachTooltip

Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@georgweiss georgweiss merged commit 061a788 into master Apr 8, 2022
@georgweiss georgweiss deleted the CSSTUDIO-1653 branch May 3, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants