BOY const PVs not translated correctly

[mdavidsaver]

When opening .opi files written by css-nsls2 3.1.6 in 3.2.15 we find that PV names where the constant value is a macro are not being translated correctly. For example, 'const://x($(M))' becomes '="M)"' when I would expect either '=$(M)' or '="$(M)"'.

FYI, in our case the macro value is a number.

[kasemir]

That might be hard to solve, because you don't know if it needs to turn into =$(M) or ="$(M)"

[mdavidsaver]

To provide some context. This constant is being used in a visibility
rule to hide some rows of widgets based on the value of a macro.

It will be interested to find out if a constant string is automatically
converted to a number in this case.

[berryma4]

Could you use a local variable instead?
loc://visibility(0)

On Wed, Mar 5, 2014 at 9:57 PM, mdavidsaver notifications@github.comwrote:

To provide some context. This constant is being used in a visibility
rule to hide some rows of widgets based on the value of a macro.

It will be interested to find out if a constant string is automatically
converted to a number in this case.

Reply to this email directly or view it on GitHubhttps://github.com//issues/412#issuecomment-36820274
.

[mdavidsaver]

We're already investigating local variables as a workaround.

Also, I checked and a rule expression "pvInt0==1" doesn't have the desired effect when the input PV is '="1" ('=1' works as expected)'. It does throw up a NullPointerException.

On Wed, Mar 5, 2014 at 9:57 PM, mdavidsaver notifications@github.comwrote:
Caused by: java.lang.NullPointerException
at org.csstudio.opibuilder.scriptUtil.PVUtil.getLong(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.mozilla.javascript.MemberBox.invoke(MemberBox.java:145)
... 36 more

[mdavidsaver]

Where are we on the translation issue?

That might be hard to solve, because you don't know if it needs to turn into =$(M) or ="$(M)"

For my part I vote for unquoted. All the usage I've seen of const:// has been with numeric values.

[kasemir]

OK, is the overall vote that we try to convert const://x($(M)) into =$(M)?

I believe the code for that is limited to org.csstudio.opibuilder.util.UpgradeUtil:

    if(pvName.startsWith("const://")) ..

There's actually a test for it in the org.csstudio.opibuilder.test plugin, so this would be a good task for somebody with a few spare cycles...

[berryma4]

reopening for validation

[berryma4]

Also, changing to 3.3