Skip to content

Duplicate code in o.c.opibuilder.* #1650

@nickbattam

Description

@nickbattam

Some of the code in o.c.opibuilder.editor is reproduced in o.c.opibuilder.tools.

ResourceSelectionGroup.java differs only by a null-check and WorkspaceResourceContentProvider.java is identical.

Are both sets of code still required for any reason, or were they left while moving functionality between different plugins and packages? Which is the 'correct' location?

I stumbled on these two while fixing Checkstyle warnings. I'd be surprised if they're the only ones.
Has there ever been a systematic review of the code looking for duplicated classes?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions