This repository was archived by the owner on Mar 20, 2020. It is now read-only.
NODE-636 Add DangerousPaths route #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
reviewed
Mar 2, 2020
| if (noop) return 'NOOP'; | ||
|
|
||
| return new Promise((resolve) => { | ||
| cp.exec("/bin/sh -c 'cat /tmp/foo.txt /etc/passwd'", (err, data) => { |
There was a problem hiding this comment.
this doesn't take any data from request which is ok but what do we do in darpa-testing-config to test these?
There was a problem hiding this comment.
That's a good point. Would it be better to just take in data from the request so that we could have darpa-testing-config sending different commands that'll trigger this rule?
bizob2828
approved these changes
Mar 2, 2020
|
These rule names seem verbose and make the nav look like shit but this works as spec'd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Pretty much followed suit with what @pmcclory-contrast did here (#13) for the ChainedCommand rule
You can test this by:
npm linkhere and in yourtest-bench-contentlocal directory.npm link @contast/test-bench-utils @contrast-test-bench-contentin a sample app directory.Example:
