Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build tweaks #58

Merged
merged 4 commits into from
Jun 6, 2024
Merged

build tweaks #58

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68b52fe
test a few changes
tough-griff Jun 5, 2024
e1a6547
npm should be lowercase
tough-griff Jun 5, 2024
76e7569
fix npm
tough-griff Jun 5, 2024
f06936e
update actions
tough-griff Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,12 @@ jobs:
- name: Set up node
uses: actions/setup-node@v3
with:
node-version: 16
architecture: x64
node-version: lts/*
Copy link
Contributor Author

@tough-griff tough-griff Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on macos, using anything less than 22 to build for 22 failed locally as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense that the node-22 build requires the node-22 includes. thank you!

- name: Update npm
run: npm install -g npm@10
# new versions of python don't include distutils. setuptools provides it.
- name: Install setuptools
run: pip install setuptools
- name: Update npm
run: npm install -g npm@8
- name: Install
run: npm ci --ignore-scripts
- name: Build
Expand All @@ -64,11 +63,8 @@ jobs:
with:
node-version: lts/*
registry-url: https://registry.npmjs.org
# new versions of python don't include distutils. setuptools provides it.
- name: Install setuptools
run: pip install setuptools
Comment on lines -67 to -69
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't need setuptools when only deplying to npm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't recall what the failure was, but i wouldn't have added this unless there was a failure.

- name: Update npm
run: npm install -g npm@8
run: npm install -g npm@10
- name: Install
run: npm ci --ignore-scripts
- name: Download artifacts
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,12 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
architecture: x64
- name: Python version
run: python --version
Comment on lines -37 to -38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than output the system version, we can look at the output from node-gyp in the install and build step. this way we confirm the version that node-gyp is actually using.

- name: Update npm
run: npm install -g npm@10
# new versions of python don't include distutils. setuptools provides it.
- name: Install setuptools
run: pip install setuptools
- name: Install dependencies
- name: Install dependencies and build
run: npm ci
- name: Show node-gyp version
run: npm ls node-gyp
Comment on lines -43 to -44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above, the npm ci step outputs the node-gyp version that's running. that doesn't always match the version that is installed as a dependency.

- name: Test
run: npm test
Loading