Merge pull request #74 from Contrast-Security-Inc/NODE-3519-retire-pr…

…ebuildify-cross

decruft pass

.github/workflows/release-no-prebuildify-cross.yml

@@ -32,15 +32,8 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 22.5.1
-      # - name: Update npm
-      #   run: npm install -g npm@10
-      # new versions of python don't include distutils. setuptools provides it.
-      # - name: Install setuptools
-      #   run: pip install setuptools
       - name: Install dependencies
         run: npm ci --ignore-scripts
-      - name: whoami
-        run: id
       # build each image inline so the matrix doesn't checkout, install, install each time.
       - name: Build alpine
         run: docker run --rm -v ${{ github.workspace }}:/repo -w /repo -u $(id -u) ghcr.io/bmacnaughton/alpine
@@ -72,13 +65,8 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: 22.5.1
-      # - name: Update npm
-      #   run: npm install -g npm@10
       - name: Install dependencies
         run: npm ci --ignore-scripts
-      # new versions of python don't include distutils. setuptools provides it.
-      - name: Install setuptools
-        run: pip install setuptools
       - name: Build
         run: npm run build:${{ matrix.build-group }}
         shell: bash
@@ -98,10 +86,8 @@ jobs:
   #     - name: Set up node
   #       uses: actions/setup-node@v4
   #       with:
-  #         node-version: 22
+  #         node-version: 22.5.1
   #         registry-url: https://registry.npmjs.org
-  #     - name: Update npm
-  #       run: npm install -g npm@10
   #     - name: Install
   #       run: npm ci --ignore-scripts
   #     - name: Download artifacts

README.md

@@ -22,25 +22,16 @@ const results = funcInfo(testFn);
 
 ## Building locally
 
-`npm run build` will build the project for your current OS and architecture. This cleans
-the prebuild directory first.
+`npm run build` will build the project for your current OS and architecture.
 
 `npm run download` will pull the most recent build artifacts from GitHub.
 
 ## Publishing
 
-Simply run `npm version` and `git push && git push --tags`. CI will take care of
-releasing.
+Simply run `npm version` and `git push && git push --tags`. The `release` workflow runs when
+a tag of the form `v1.2.3` is pushed.
 
-## Temporary note
+## Temporary code
 
-```
-bruce:~/.../csi/fn-inspect$ npm uninstall prebuildify-cross
-
-removed 226 packages, and audited 425 packages in 784ms
-
-89 packages are looking for funding
-  run `npm fund` for details
-
-found 0 vulnerabilities
-```
+Node version 22.5.0 ships with a very broken `npm`. This hardcodes version 22.5.1 until
+github actions stops defaulting to 22.5.0 when node version 22 is specified.

package.json

@@ -30,8 +30,8 @@
     "prebuild": "npm run clean",
     "build": "prebuildify -t 16.9.1 -t 18.7.0 -t 20.5.0 -t 22.2.0 --strip --napi false",
     "build:linux": "prebuildify-cross -i centos7-devtoolset7 -i alpine -i linux-arm64 -t 16.9.1 -t 18.7.0 -t 20.5.0 -t 22.2.0 --strip --napi false",
-    "build:darwin": "prebuildify -t 16.9.1 -t 18.7.0 -t 20.5.0 -t 22.2.0 --strip --napi false --arch x64+arm64",
-    "build:win32": "prebuildify -t 16.9.1 -t 18.7.0 -t 20.5.0 -t 22.2.0 --strip --napi false",
+    "build:darwin": "npm run build -- --arch x64+arm64",
+    "build:win32": "npm run build",
     "clean": "rimraf build/ coverage/ prebuilds/",
     "download": "node scripts/download-artifacts.js",
     "test": "c8 --reporter lcov --reporter text mocha .",

scripts/build-generic.sh

@@ -12,8 +12,7 @@ target=$1
 
 common="-t 16.9.1 -t 18.7.0 -t 20.5.0 -t 22.2.0 --strip --napi false"
 
-id
-ls -l . node_modules/.bin node_modules/prebuildify
+# this is useful for debugging.
 npm ls
 
 case $target in