Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and cleanup #4

Merged
merged 7 commits into from
Feb 27, 2017
Merged

Rename and cleanup #4

merged 7 commits into from
Feb 27, 2017

Conversation

gbrener
Copy link
Contributor

@gbrener gbrener commented Feb 27, 2017

This PR is a continuation of @DavidMertz's work on splitting off TextAdapter from IOPro. With this PR merged in, the project should be buildable (with all tests passing) for both Python 2.7 and Python 3.5 on Ubuntu 16.

A few key differences:

  • "TextAdapter" package is now called "textadapter"
  • Cython code for the core TextAdapter low-level data structures is in a directory called "core"
  • README now includes instructions on how to build, install, and test
  • All files not related to TextAdapter are gone. There may still be some dead code, but this can be removed in a future PR
  • Dynamic loading of modules/classes/functions in __init__.py is replaced with static loading
  • Due to shared library issues with a couple of conda packages, versions of the pcre and zlib conda packages are pinned in the meta.yaml

@gbrener gbrener merged commit bd5de6c into master Feb 27, 2017
@gbrener gbrener deleted the rename_and_cleanup branch February 27, 2017 20:13
@gbrener gbrener mentioned this pull request Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant