ci(release): fail closed on missing license evidence - #240
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hourly loop: exact head |
|
@coderabbitai review |
|
Live re-verify (2026-08-17)Exact head Merge is blocked only by the live ruleset: Requested Copilot review on this exact head. This comment is not approval. Independent last-push review is still required before merge. |
|
@coderabbitai review |
1 similar comment
|
@coderabbitai review |
|
4529c6b to
a9f69d8
Compare
The contract test requires an explicit refs/heads/main guard so a workflow_dispatch on another ref cannot be treated as release evidence.
a9f69d8 to
73e45e6
Compare
…ader Production line coverage failed because the integration framing client unwrapped write/shutdown after the listener already fail-closed. Drive those reader arms through the race-safe helper and tolerate a closed peer during the public framing contract. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head0f075706909c3dc36430fd05dddd5dffb4fa2971. -
Head SHA:
0f075706909c3dc36430fd05dddd5dffb4fa2971 -
Workflow run: 32100400739
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow (2 files)"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow (2 files)"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (2 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (2 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
2 participants
Why
Protected
maincurrently has noLICENSE/COPYINGfile, GitHub reports no detected repository license, andCargo.tomldeclares neitherlicensenorlicense-file. That is an acquisition/release-readiness gap, but this PR must not invent legal terms or claim rights that have not been established.What
license-filedeclarations.workflow_dispatchpreflight. It intentionally fails on the current repository until an authorized owner adds reviewed terms; it does not make every ordinary PR fail while that governance decision is pending.TDD
c31a2b454d121d3e187e8955fe6b1eb05d65294c4e8878fc8b1bf5acb9283fc4c970862b4df687b5f2d33cae7cb54e07743d3bbadf6f054f05115cf610973662ce969303a4b3dc8cee47cc86461bc316Scope
This PR adds evidence/preflight only. It does not choose a license, change
publish = false, publish a crate, certify third-party compatibility, or assert rights to assessment content. Those remain explicit owner/legal-governance inputs.Do not merge until required checks on the unchanged exact head and qualifying independent non-author review pass.